search

testdouble / jasmine-rails

A Jasmine runner for rails projects that's got you covered in both the terminal and the browser
http://rubygems.org/gems/jasmine-rails
MIT License
377 stars 154 forks source link

Allow adding reporters #126

Closed shepmaster closed 10 years ago

shepmaster commented 10 years ago

I'd like to get JUnit output for Jenkins CI integration. There's an example of how one company patched jsamine-rails to enable this, but as they state, it's "highly specific to our setup".

I'm interested in adding this ability to jasmine-rails proper. Do you have any suggestions on how you would like to see it handled, or should I just hack some things in and send a PR? Sorry if this info is in a Contributing file somewhere, but I didn't see it with a quick skim.

searls commented 10 years ago

Yeah, it's tricky. I wouldn't accept a PR that cluttered things up further, but I'd absolutely entertain the addition of a hook that made it easier to both (a) add a custom reporter [something you could do now without modifying jasmine-rails, I suppose] and (b) write out the reporter's results to a file.

It seems to me that just providing a hook method (even a silly little thing like how #125 did it) would be enough to give you the opportunity to add your own junit reporter. With that, if you develop a nice one, then maybe it'd make sense to merge that into the main gem.

searls commented 10 years ago

Closing now pending that PR if you choose to write it :)