search

testdouble / jasmine-rails

A Jasmine runner for rails projects that's got you covered in both the terminal and the browser
http://rubygems.org/gems/jasmine-rails
MIT License
377 stars 154 forks source link

fix failed count in ConsoleReporter when there are skipped_or_pending_specs #150

Closed larsklevan closed 9 years ago

larsklevan commented 9 years ago

The failures output in ConsoleReporter is incorrect if skipped_or_pending_specs is greater than 0.

Running:

rake spec:javascripts SPEC=myspec

Before:

4 specs, 2081 skipped or pending, -2081 failures in 0.43s.

After:

4 specs, 2081 skipped or pending, 0 failures in 0.43s.

Verified that it works if you run the whole test suite and if there is a failure.

searls commented 9 years ago

Thanks!

searls commented 9 years ago

Landed in 0.10.4

dgrawunder commented 9 years ago

This fix causes wrong failed count if skipped or pending specs are present. Reverting this fix solves the problem. Even with the reverted fix I am not able to reproduce the problem leading to this fix.

searls commented 9 years ago

@larsklevan can you please try to work with @dgrawunder to understand what went wrong?

larsklevan commented 9 years ago

I tested this again with a clean sandbox and it looks like my patch is incorrect. I must have overridden something in my environment that was causing it to break. My apologies for not testing it better - please revert the patch.