Add option to not use the PhantomJS gem executable

testdouble / jasmine-rails

A Jasmine runner for rails projects that's got you covered in both the terminal and the browser

http://rubygems.org/gems/jasmine-rails

MIT License

378 stars 154 forks source link

Add option to not use the PhantomJS gem executable #154

Closed edds closed 9 years ago

edds commented 9 years ago

The PhantomJS gem will automatically download and install a copy of PhantomJS. The download and installation is over http and without a checksum, which poses a security risk.

Maintains current default behaviour of downloading and will only skip the download if the config option is set.

I believe this will resolve https://github.com/searls/jasmine-rails/issues/133

searls commented 9 years ago

I'm :+1: all for having the default be easy and give folks the option to opt out. Would you mind making a note in the README?

edds commented 9 years ago

I have written a couple of lines for the README. If you want them changing at all let me know.

searls commented 9 years ago

awesome @edds, thanks

searls commented 9 years ago

Landed in 0.10.6

edds commented 9 years ago

\o/ Thanks @searls.

fofr commented 9 years ago

:fireworks: :tada: