Closed radar closed 9 years ago
Hey Ryan, I'm just about to leave for the airport for vacation for a week so I won't have time to look at this :( :( :(
Oh no and I expected you to work strenuously/tirelessly on this until it was fixed ASAP. Actually, no I didn't because I'm not an asshole.
Dude it's open source!! If you've got a vacation to and enjoy your vacation! You deserve it.
<3
On 21 Mar 2015, at 00:06, Justin Searls notifications@github.com wrote:
Hey Ryan, I'm just about to leave for the airport for vacation for a week so I won't have time to look at this :( :( :(
— Reply to this email directly or view it on GitHub.
Hey @radar I somehow misread this issue initially; seems like things work fine under Sprockets@2.x ,but this issue is opened just to point out that it doesn't work under Sprockets@3.x?
Sigh.
That is correct.
On 9 Apr 2015, at 00:45, Justin Searls notifications@github.com wrote:
Hey @radar I somehow misread this issue initially; seems like things work fine under Sprockets@2.x ,but this issue is opened just to point out that it doesn't work under Sprockets@3.x?
Sigh.
— Reply to this email directly or view it on GitHub.
Were you doing a favor and testing sprockets for us or is it coming soon / coupled to Rails 5 maybe?
Curious how much time I should invest in debugging this.
On Mon, Apr 13, 2015 at 12:15 AM, Ryan Bigg notifications@github.com wrote:
That is correct.
On 9 Apr 2015, at 00:45, Justin Searls notifications@github.com wrote:
Hey @radar I somehow misread this issue initially; seems like things work fine under Sprockets@2.x ,but this issue is opened just to point out that it doesn't work under Sprockets@3.x?
Sigh.
— Reply to this email directly or view it on GitHub.
Reply to this email directly or view it on GitHub: https://github.com/searls/jasmine-rails/issues/159#issuecomment-92142913
I was attempting to use the new version of Sprockets to see if it fixed an issue that I had at the time. (It didn't.) This error popped up in the meantime and I thought to raise an issue to alert you to possible problems with Sprockets 3.
Sprockets 3.0.0 was released two days ago and is now the default in any new Rails application.
Heh, well thanks for the heads up even though I squandered it.
On Wed, Apr 15, 2015 at 12:20 AM, Ryan Bigg notifications@github.com wrote:
I was attempting to use the new version of Sprockets to see if it fixed an issue that I had at the time. (It didn't.) This error popped up in the meantime and I thought to raise an issue to alert you to possible problems with Sprockets 3.
Sprockets 3.0.0 was released two days ago and is now the default in any new Rails application.
Reply to this email directly or view it on GitHub: https://github.com/searls/jasmine-rails/issues/159#issuecomment-93183303
I just updated to latest sprockets 3.0.2, and it worked:
[arthurnn@ralph bad-sprockets-bad]$ bin/rake assets:precompile
I, [2015-04-27T15:59:41.331971 #27608] INFO -- : Writing /Users/arthurnn/dev/bad-sprockets-bad/public/assets/jasmine-6d8420ac17d03d520e8e3b737e184ae2f7dddbaeb307311439ba129c21ddda29.css
I, [2015-04-27T15:59:41.341528 #27608] INFO -- : Writing /Users/arthurnn/dev/bad-sprockets-bad/public/assets/boot-61490ea53568f244f820be0968f7887a199034e14bd42292012b1388b26eccb5.js
I, [2015-04-27T15:59:41.400489 #27608] INFO -- : Writing /Users/arthurnn/dev/bad-sprockets-bad/public/assets/json2-925947d3d711c4441a9db20f51215fbf5c119d2a3b51cadb2c9031907d8014b5.js
I, [2015-04-27T15:59:41.429016 #27608] INFO -- : Writing /Users/arthurnn/dev/bad-sprockets-bad/public/assets/jasmine-36ccb16d3b8cb028dbb4ba8678e420e521189afd8d74fe536f6f321c86afeb59.js
I, [2015-04-27T15:59:41.478933 #27608] INFO -- : Writing /Users/arthurnn/dev/bad-sprockets-bad/public/assets/jasmine-html-049b99fd00a85bdc3b8269b56be1f7e9d1f1cc816c51aeb8f55fce59937ff7bf.js
I, [2015-04-27T15:59:41.730104 #27608] INFO -- : Writing /Users/arthurnn/dev/bad-sprockets-bad/public/assets/jasmine-specs-6a73f68bbcb6b2f72f30b15933d6a8a314dc84516ab01ed1e970aff74d10e96e.js
I, [2015-04-27T15:59:41.740461 #27608] INFO -- : Writing /Users/arthurnn/dev/bad-sprockets-bad/public/assets/jasmine-specs-01ba4719c80b6fe911b091a7c05124b64eeece964e09c058ef8f9805daca546b.css
doing more further investigation. seems like version 3.0.0.beta.10 fixed the problem. To be more precise, my guess is that https://github.com/rails/sprockets/commit/896f93c79a024ff70e307c84c49aba227f7f7b87 was the fix for this problem. Anyhow, this can be closed, as it is already fixed in sprockets 3. cc @josh
Wow @arthurnn thanks for taking some time out of your day to clear this for us. Truly!
Thanks @arthurnn!
I have a proof of concept app here: https://github.com/radar/bad-sprockets-bad
Steps to reproduce
rake assets:precompile
Expected behaviour
Actual behaviour
spec/javascripts
Here's the stacktrace: