spec_runner: target the current version of IE

testdouble / jasmine-rails

A Jasmine runner for rails projects that's got you covered in both the terminal and the browser

http://rubygems.org/gems/jasmine-rails

MIT License

378 stars 154 forks source link

spec_runner: target the current version of IE #171

Closed henrik closed 8 years ago

henrik commented 8 years ago

Without this, IE9 would run in quirks mode, giving IE8-type "isArray" errors with React.

More details: http://stackoverflow.com/a/29828955/6962

searls commented 8 years ago

Cool. Any feedback from anyone else?

searls commented 8 years ago

Merged in good faith that this won't cause anyone else issues

henrik commented 8 years ago

Thank you, @searls. Pull-requested in good faith. IE compatibility modes appears to be a complex matter, but it seems this will make IE9 run tests in IE9 mode, which is probably what most people want. If someone does have tests that passed in some "earlier" mode (as though running in an earlier IE), hopefully this change won't break anything – I suspect IE adds support for new features but rarely removes them…