testdouble / jasmine-rails

A Jasmine runner for rails projects that's got you covered in both the terminal and the browser
http://rubygems.org/gems/jasmine-rails
MIT License
378 stars 154 forks source link

Allow passing config yaml file name from environment #172

Closed PericlesTheo closed 8 years ago

PericlesTheo commented 8 years ago

Hey humans,

It would be great if one could pass a custom yml file instead of the default one. Scenarios include having a separate application.js for legacy code and a current one.

If you do have a custom yml file then you would simply need to add the environment variable from the console before firing up the test from the web or otherwise.

RAILS_ENV=test JASMINE_CONFIG=jasmine_legacy.yml bundle exec rake spec:javascript or JASMINE_CONFIG=jasmine_legacy.yml bundle exec rails server

WDYT?

Zeneixe commented 8 years ago

If you have better solutions, any other change that allows having different yml files would be very useful

Cheers!

searls commented 8 years ago

looks good to me. doesn't seem like it really needs another test