Closed searls closed 8 years ago
I'm able to verify this fix does work locally by reproducing the problem and then seeing this fix it. The automated tests for some reason don't succumb to the same issue
Apologies for dropping the ball on this. Summer of talks and travels. Will take a look tonight.
-RJ
On Sat, Sep 19, 2015 at 2:10 PM, Justin Searls notifications@github.com wrote:
Continuing work on @rudyjahchan's #162 with an intent to get that merged in Resolves #121 You can view, comment on, or merge this pull request online at: https://github.com/searls/jasmine-rails/pull/173 -- Commit Summary --
- Get tests running
- Ensure test enviroment when running tests
- Revert "Get tests running"
- refactor structure a bit
Preserve whatever arguments the user sends rake -- File Changes -- M lib/tasks/jasmine-rails_tasks.rake (12) -- Patch Links -- https://github.com/searls/jasmine-rails/pull/173.patch https://github.com/searls/jasmine-rails/pull/173.diff
Reply to this email directly or view it on GitHub: https://github.com/searls/jasmine-rails/pull/173
No need, I'm happy with it.
@searls Thanks for this and everything. Cheers.
-RJ
On Sat, Sep 19, 2015 at 2:17 PM, Justin Searls notifications@github.com wrote:
No need, I'm happy with it.
Reply to this email directly or view it on GitHub: https://github.com/searls/jasmine-rails/pull/173#issuecomment-141708253
Continuing work on @rudyjahchan's #162 with an intent to get that merged in
Resolves #121