search

testdouble / jasmine-rails

A Jasmine runner for rails projects that's got you covered in both the terminal and the browser
http://rubygems.org/gems/jasmine-rails
MIT License
378 stars 154 forks source link

preserve exit code when running specs in non-test env #174

Closed bunnymatic closed 8 years ago

bunnymatic commented 8 years ago

We recently picked up the 0.12.0 branch. I noticed that you merged in this fix by @rudyjahchan https://github.com/searls/jasmine-rails/commit/4691ac7c9554eb49c3867c8223e4a9f5e74f511f with the tiny change hands the full set of ARGV to rake. That seems a little strange given that this task is supposed to be running only the javascript tests so if I run rake with any other tasks included, they'll get run twice.

rake spec spec:javascripts

will run the spec task twice before running spec:javascripts.

I also found that the exit code is not preserved so if you were counting on this command to trigger something else (while not in test mode) like

rake spec spec:javascripts && cap deploy acceptance

this would deploy code even if the JS tests failed.

This commit adjusts the rake call in non-test mode to call only the spec:javascripts and adds a bit of logic to properly handle a failing exit code.

searls commented 8 years ago

Yup, after reviewing this line comment by @rudyjahchan I completely agree with your points and this PR.

searls commented 8 years ago

Landed in 0.12.1

bunnymatic commented 8 years ago

Awesome. thanks

On Sun, Sep 27, 2015 at 6:52 AM, Justin Searls notifications@github.com wrote:

Landed in 0.12.1

— Reply to this email directly or view it on GitHub https://github.com/searls/jasmine-rails/pull/174#issuecomment-143558986.