search

testdouble / jasmine-rails

A Jasmine runner for rails projects that's got you covered in both the terminal and the browser
http://rubygems.org/gems/jasmine-rails
MIT License
378 stars 154 forks source link

Should have non-zero return value for failing specs #182

Closed yevgenko closed 8 years ago

yevgenko commented 8 years ago

When I run the following command on the suite with failing specs, i.e. failures > 0:

bundle exec rake spec:javascript

Expected: echo $? to NOT be 0

Actual result: 0

Workaround

RAILS_ENV=test be rake spec:javascript

Source

https://github.com/searls/jasmine-rails/commit/12cc6408c7e4769eb6c62c3e73ff0a2042571136

Proposal

Perhaps it would be less confusing to stick with one command and update documentation accordingly?

pironim commented 8 years ago

let me link this issue https://github.com/searls/jasmine-rails/pull/176

searls commented 8 years ago

I still cannot reproduce the stated problem. Closing until we can get one going.