Closed searls closed 7 years ago
Ok folks, real talk: I haven't used jasmine-rails myself for well over 4 years at this point, and while these deprecation warnings in Rails 5 should be dealt with, I just don't have the time or caremad to deal with them. Applying the cry-for-help label for any users interested in figuring out how to address the deprecation warnings in a way that doesn't break support for Rails 3.2 & up or Ruby 1.9.
Gauntlet: lain.
Are you prepared to bump the major version to fix some of these deprecations or would you prefer not to? before_filter
for instance, can be updated to before_action
but then you lose compatibility with Rails 3.
I did this ridiculousness in lots of places because I wasn't quite ready to drop 3.x support: https://github.com/thoughtbot/clearance/blob/master/app/controllers/clearance/users_controller.rb#L2-L10
Sounds like it might not be quite so bad in jasmine-rails' case as it looks like there's only one controller generating filter warnings.
@derekprior because there is so little code in this library, I think maintaining existing support is feasible (and I know a lot of users are on very old projects).
If the if-else branching gets much worse, one option would be to define multiple ruby files for each major Rails version and just load them conditionally on a version check
Was about to suggest your solution there @derekprior :) It's not too bad with a conditional send ¯_(ツ)_/¯
@benlovell merged
@chrisarcand could I recruit you to try to whack whatever deprecation warnings that remain using this sort of branching method? It'd be nice to have a consistent approach for switching based on rails version rather than littering rails constants all over duplicatively
@searls Sure
On Saturday, September 10, 2016, Justin Searls notifications@github.com wrote:
@benlovell https://github.com/benlovell merged
@chrisarcand https://github.com/chrisarcand could I recruit you to try to whack whatever deprecation warnings that remain using this sort of branching method? It'd be nice to have a consistent approach for switching based on rails version rather than littering rails constants all over duplicatively
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/searls/jasmine-rails/issues/187#issuecomment-246087555, or mute the thread https://github.com/notifications/unsubscribe-auth/ACUWGmfhQulVTQy390pqkmSA8raF1zCcks5qoi6kgaJpZM4ICeOU .
Chris Arcand @chrisarcand
Landed in 0.14.1
Here's what I see when I run under Rails 5 right now:
That is a LOT of deprecation warnings.