search

testdouble / jasmine-rails

A Jasmine runner for rails projects that's got you covered in both the terminal and the browser
http://rubygems.org/gems/jasmine-rails
MIT License
377 stars 154 forks source link

Remove Rails 5 request spec params deprecation #198

Closed benlovell closed 8 years ago

benlovell commented 8 years ago

Removes deprecations of the form:

DEPRECATION WARNING: ActionDispatch::IntegrationTest HTTP request
methods will accept only
the following keyword arguments in future Rails versions:
params, headers, env, xhr, as

Examples:

get '/profile',
  params: { id: 1 },
  headers: { 'X-Extra-Header' => '123' },
  env: { 'action_dispatch.custom' => 'custom' },
  xhr: true,
  as: :json
benlovell commented 8 years ago

Unrelated build failure is unrelated. Something about installing phantomjs on travis...

searls commented 8 years ago

Thanks Ben! With Kaigi prep I won't be able to dig into this until next week but thanks!

On Sep 5, 2016, at 17:46, Ben Lovell notifications@github.com wrote:

Unrelated build failure is unrelated. Something about installing phantomjs on travis...

― You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

benlovell commented 8 years ago

Thanks ❤️

searls commented 8 years ago

Landed in 0.14.0