Updated `rake spec:javascript` so it doesn't short circuit

testdouble / jasmine-rails

A Jasmine runner for rails projects that's got you covered in both the terminal and the browser

http://rubygems.org/gems/jasmine-rails

MIT License

378 stars 154 forks source link

Closed jason-o-matic closed 7 years ago

jason-o-matic commented 7 years ago

Updated rake spec:javascript so it doesn't short circuit a chain of rake tasks by using exec.

searls commented 7 years ago

History of this file using system vs. exec:

Added by @rudyjahchan in 4691ac7c9554eb49c3867c8223e4a9f5e74f511f to fix the what-if-not-running-in-TEST env - see #162
Here, because of unconfirmed JRuby reasons: https://github.com/searls/jasmine-rails/commit/12cc6408c7e4769eb6c62c3e73ff0a2042571136 - see #176

searls commented 7 years ago

Going to merge this blind in hopes that c1352e9ae46643b66df0c1100f80fd76ab0e478d saves us from intermittent phantomjs failures

searls commented 7 years ago

Landed in 0.14.0