Remove alias_method_chains for OfflineAssetPaths

[chrisarcand]

Closes #187

#alias_method_chain is deprecated in Rails 5. Use Ruby 2's #prepend instead.

AFAIK this should cap off Rails 5 support with #198. The other warnings in the related issue I assume are just from the example app.

I do not use jasmine-rails, so I would recommend someone with a bit more knowledge actually give this a try - especially with Rails 3, as I just checked the 3.2 stable branch and noted the class/method name change that was done from that version. Also I'm not sure what Sprockets::Rails::Helper actually referred to. But I believe it was being included somewhere else anyway (Probably Base), so a prepend to that won't work anymore anyway, hence my use of Base.

[searls]

I do not use jasmine-rails

Like any good group of open source maintainers, none of us actually maintaining the gem use the gem anymore. We simply react to e-mail notifications when people we don't know on the Internet complain about things not working.

[chrisarcand]

😄👍

*Never used jasmine-rails, so someone should probably double check that I didn't ruin everything for those fine Internet-dwelling people that do use it who would come here to find out that I ruined everything and curse my name forever. ...or something like that.

On Sunday, September 18, 2016, Justin Searls notifications@github.com wrote:

I do not use jasmine-rails

Like any good group of open source maintainers, none of us actually maintaining the gem use the gem anymore. We simply react to e-mail notifications when people we don't know on the Internet complain about things not working.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/searls/jasmine-rails/pull/202#issuecomment-247887362, or mute the thread https://github.com/notifications/unsubscribe-auth/ACUWGqaWgU9wKahf0-QJxGv2EVme2qnXks5qrcO4gaJpZM4KAAMz .

Chris Arcand @chrisarcand

[searls]

Wait, doesn't this PR break ruby@<2 users?

[chrisarcand]

"Yes", but I thought < Ruby 2 wasn't supported based on CI builds all using Ruby 2.

Whoops, well, if you want to continue supporting 1.9.3 I'll add a conditional for ye olde alias method chain implementation, then.

On Sunday, September 18, 2016, Justin Searls notifications@github.com wrote:

Wait, doesn't this PR break ruby@<2 users?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/searls/jasmine-rails/pull/202#issuecomment-247888583, or mute the thread https://github.com/notifications/unsubscribe-auth/ACUWGhgIqXGoKnzoA3_O8gdq0-qhU4Mhks5qrcXigaJpZM4KAAMz .

Chris Arcand @chrisarcand

[searls]

I'm working on adding 1.9 to the build matrix

[searls]

Continuing this in #204

[searls]

Landed in 0.14.1