search

testdouble / jasmine-rails

A Jasmine runner for rails projects that's got you covered in both the terminal and the browser
http://rubygems.org/gems/jasmine-rails
MIT License
378 stars 154 forks source link

PhantomJS (2.1.1) crashes when the url is not followed by a newline #212

Closed dkanai closed 6 years ago

dkanai commented 7 years ago

PhantomJS WebPage.open doesn't work when the url has no newline at the end.

searls commented 7 years ago

What's this require("system") business?

terryyin commented 7 years ago

console.error will raise another error which led to the endless recursion.

If you still want to output the stderr, then require("system") is a way of doing it. Otherwise just output to STDOUT.

BTW, is there a way to unit test this piece or code?

searls commented 7 years ago

Ah, I see. As for a way to unit test it, not beyond the existing test of the functionality this replaces.

Unfortunately it looks like most of the build is broken due to a breaking nokogiri version, so we should probably fix that first, since I'm not sure when require('system') was introduced to phantom

fmachella commented 6 years ago

It fixes a problem that I have too. I suggest to accept asap

searls commented 6 years ago

can you update the PR and get the build passing?