search

testdouble / jasmine-rails

A Jasmine runner for rails projects that's got you covered in both the terminal and the browser
http://rubygems.org/gems/jasmine-rails
MIT License
378 stars 154 forks source link

Allow to pass several options to PhantomJS via jasmine.yml. Fix #192 #217

Closed bolshakov closed 6 years ago

bolshakov commented 6 years ago

Currently it doesn't work. See #192 

phantom_options: --debug=true --web-security=false
searls commented 6 years ago

Could you please fix this build failure prior to merge -- glancing at it, I presume it's blowign up on a nil for users who do not provide custom options: https://travis-ci.org/searls/jasmine-rails/jobs/272800047

searls commented 6 years ago

Also, as a user I'd expect this to work if they provide:

phantom_options: --one-thing --two-thing=true

I wouldn't expect to have to break out a yaml list for each CLI arg since they're normally space-delimited, so I'd recommend just splitting on whitespace (e.g. split(/\s+/) instead of dealing with YAML arrays.

bolshakov commented 6 years ago

It works on ruby >= 2.0

searls commented 6 years ago

Thanks for making the change so quickly

searls commented 6 years ago

landed in 0.14.2

bolshakov commented 6 years ago

Woohoo! Thanks