search

testdouble / jasmine-rails

A Jasmine runner for rails projects that's got you covered in both the terminal and the browser
http://rubygems.org/gems/jasmine-rails
MIT License
377 stars 154 forks source link

phantom2 needs newline after address (fixes #212) #223

Closed fmachella closed 6 years ago

fmachella commented 6 years ago

it solve phantomjs 2.1.1 issue about newline.

Fixes #212

searls commented 6 years ago

can you please write "fixes #212" in your PRs so they're referenced and automatically close when a PR is merged?

fmachella commented 6 years ago

Is it good for you?

searls commented 6 years ago

I'm just sharing a protip about how github automatically parses. When the summary of the PR text includes "fixes #xxx" or "resolves #xxx", then issue #xxx will automatically be linked & then (when merged) automatically closed.

searls commented 6 years ago

Landed in 0.14.5