search

testdouble / jasmine-rails

A Jasmine runner for rails projects that's got you covered in both the terminal and the browser
http://rubygems.org/gems/jasmine-rails
MIT License
378 stars 154 forks source link

always use console log instead of error #224

Closed fmachella closed 6 years ago

fmachella commented 6 years ago

It seams that onError catches console.error and this create a circular invokation. Maybe we could redirect all in stdout, this is a solution and works well

searls commented 6 years ago

can you provide a test case for this? Was it caused by the previous PRs today?

fmachella commented 6 years ago

Yes test case is simple. Create a simple test that give an error message for example empty one (without assertions), and phantom start to loop and exit after a while. The old PR instead seams to be catched by spec= filter and start to skip all tests :( I'm sry we have to revert. Can you please take a look? use version 0.14.4

fmachella commented 6 years ago

describe("baz", function(){ it("errr", function(){

}); });

searls commented 6 years ago

landed in 0.14.6