search

testdouble / jasmine-rails

A Jasmine runner for rails projects that's got you covered in both the terminal and the browser
http://rubygems.org/gems/jasmine-rails
MIT License
378 stars 154 forks source link

remove wrong workaround #225

Closed fmachella closed 6 years ago

fmachella commented 6 years ago

we have to remove the workaround that is catched by spec filter as blank and this let skill all tests

searls commented 6 years ago

Can you explain?

fmachella commented 6 years ago

You can reproduce by command line, just copy and paste the command executed by rake spec:javascript. The address that we modified, append just after the query string "spec=" a newline character. The result is that the spec filter parse a "spec=\n" and accept newline as parameter, this means that all test are skipped. I tried to modify gem in local and works. The guy suggested 2 modification in code but only the second (console log looping) is the one that fixes really the problem.

searls commented 6 years ago

Ok will revert and relaunch. In the future to fix this issue I'm going to insist we have a test case for it.

searls commented 6 years ago

landed in 0.14.7

fmachella commented 6 years ago

We should implement also a test suite in order to avoid this confusing bugfix