search

testdouble / jasmine-rails

A Jasmine runner for rails projects that's got you covered in both the terminal and the browser
http://rubygems.org/gems/jasmine-rails
MIT License
378 stars 154 forks source link

fix deprecation warning on Rails 5.2 #229

Closed coorasse closed 6 years ago

coorasse commented 6 years ago

DEPRECATION WARNING: The success? predicate is deprecated and will be removed in Rails 6.0. Please use successful? as provided by Rack::Response::Helpers.

searls commented 6 years ago

Don't want to merge this until the build is passing. Just restarted master to make sure it's not failing for some environmental reason (it's been 7 months) https://travis-ci.org/searls/jasmine-rails/builds/293826963

If the above build is still green, I think you will need to branch on responds_to? in order to only call successful? when defined and fall back on success

timdiggins commented 6 years ago

@searls The failures aren't to do with the change in this patch, but instead are failures fixed in #231 and (putatively) in #233 (though this has weird other (probably transient) problems

timdiggins commented 6 years ago

as evidenced by https://travis-ci.org/timdiggins/jasmine-rails/builds/404998423

searls commented 6 years ago

Closed in favor of #235 -- thanks!

searls commented 6 years ago

Landed in 0.14.8. Thanks again!