search

testdouble / jasmine-rails

A Jasmine runner for rails projects that's got you covered in both the terminal and the browser
http://rubygems.org/gems/jasmine-rails
MIT License
377 stars 154 forks source link

fix travis on rails-5.0 and rails-5-sprockets-4 #233

Closed timdiggins closed 6 years ago

timdiggins commented 6 years ago

Travis is failing on rails 5.0 and rails 5-sprockets-4 variants because of a missing puma from the Gemfile.

searls commented 6 years ago

Is there any way at all this can be made to fix the Ruby 2.1 build?


current ruby version is 2.1.0.
An error occurred while installing xpath (3.1.0), and Bundler```
timdiggins commented 6 years ago

The travis failure on the main fork is weird. It works fine (with no code/git differences) on https://travis-ci.org/timdiggins/jasmine-rails/builds/404994158 --

The error is in ruby 2.1 x rails 4.0 (untouched by this PR) which is giving a bundler requirement error:

Gem::RuntimeRequirementNotMetError: xpath requires Ruby version >= 2.2. The
current ruby version is 2.1.0.
An error occurred while installing xpath (3.1.0), and Bundler
cannot continue.
Make sure that `gem install xpath -v '3.1.0' --source 'https://rubygems.org/'`
succeeds before bundling.

In rails-4.1:
  poltergeist was resolved to 1.18.1, which depends on
    capybara was resolved to 2.18.0, which depends on
      xpath

https://travis-ci.org/searls/jasmine-rails/jobs/404996988

As opposed to successful bundle (which doesn't mention capybara or poltergeist or xpath) at: https://travis-ci.org/searls/jasmine-rails/jobs/404996988

timdiggins commented 6 years ago

@searls just tested this locally on my machine and am getting roughly the same error (quicker with bundler v1.16.2): xpath-3.1.0 requires ruby version >= 2.2, which is incompatible with the current version, ruby 2.1.0p0.

Can we just move from 2.1 to 2.2 for everything?

timdiggins commented 6 years ago

NB: 2.1 end of support was over a year ago https://www.ruby-lang.org/en/news/2017/04/01/support-of-ruby-2-1-has-ended/ and 2.2 end of support was about a month ago https://www.ruby-lang.org/en/news/2018/06/20/support-of-ruby-2-2-has-ended/

searls commented 6 years ago

I'm fine if this PR drops it

searls commented 6 years ago

Do you know why https://travis-ci.org/searls/jasmine-rails/jobs/405011225 broke? Or is it flakey and does it need to be re-run?

timdiggins commented 6 years ago

@searls adding gem 'test-unit' to the Gemfile seems to have fixed it. All green now

searls commented 6 years ago

Thanks for your doggedness in getting this through. Once your other branches are green ping me to merge