testdouble / quibble

Makes it easy to replace require'd dependencies.
94 stars 25 forks source link

fix: loader stomping context from other loaders #108

Closed JakobJingleheimer closed 7 months ago

JakobJingleheimer commented 7 months ago

Fixes https://github.com/testdouble/testdouble.js/issues/525

JakobJingleheimer commented 7 months ago

Sorry, for the noise: I tried to rename the branch to something more useful. I swear I've done that before without GitHub flipping the table.

giltayar commented 7 months ago

I'm missing a test that checks this, but I'll try and add one now.

JakobJingleheimer commented 7 months ago

You're welcome to use the tests from jakobjingleheimer/nodejs-loaders. Those loaders all work with testdouble. I can add some here if you'd like (they use the same node:assert & node:test)

searls commented 7 months ago

Landed in v0.9.2