testdouble / quibble

Makes it easy to replace require'd dependencies.
94 stars 25 forks source link

fix bug in handling internal modules #33

Closed giltayar closed 4 years ago

giltayar commented 4 years ago

Working on testdouble exposed a dormant bug: the quibble ESM loader handles internal node.js module (e.g. 'fs') poorly, as in not at all. Amazing that I just found that out now!

Anyway, fixed, and as usual, to continue with testdouble.js (all tests pass when I copy over the fix!), I need a new version.

(Sorry about the constant to and fro. I would have npm-linked testdouble to quibble until everything worked, but the TS support kept changing the quibble's import-s into require-s, so I can't npm-link the module to check it. Hopefully, this is the last one... :->)

searls commented 4 years ago

Ok, landed in 0.6.3