search

testdouble / quibble

Makes it easy to replace require'd dependencies.
94 stars 25 forks source link

Deprecation warning - Obsolete loader hook(s) supplied #52

Closed anonrig closed 2 years ago

anonrig commented 3 years ago

I'm receiving the following deprecation warning on Node 17.0.1 on Macbook M1 (2020) running on Mac 12.0.1 Monterey.

(node:27005) DeprecationWarning: Obsolete loader hook(s) supplied and will be ignored: getFormat, getSource
    at Function.pluckHooks (node:internal/modules/esm/loader:137:39)
    at ESMLoader.addCustomLoaders (node:internal/modules/esm/loader:176:21)
    at initializeLoader (node:internal/process/esm_loader:82:19)
    at async loadESM (node:internal/process/esm_loader:87:5)
    at async handleMainPromise (node:internal/modules/run_main:65:12)
georgecrawford commented 2 years ago

I still see this warning with quibble v0.6.8 on Node v16.13.1. Have I done something wrong?

> mocha --trace-warnings --loader=quibble 'src/**/*.spec.js'

(node:559) ExperimentalWarning: --experimental-loader is an experimental feature. This feature could change at any time
    at emitExperimentalWarning (node:internal/util:224:11)
    at initializeLoader (node:internal/process/esm_loader:59:3)
    at loadESM (node:internal/process/esm_loader:87:11)
    at runMainESM (node:internal/modules/run_main:47:21)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:78:5)
    at node:internal/main/run_main_module:17:47
(node:559) DeprecationWarning: Obsolete loader hook(s) supplied and will be ignored: getFormat, getSource
    at Function.pluckHooks (node:internal/modules/esm/loader:137:39)
    at ESMLoader.addCustomLoaders (node:internal/modules/esm/loader:176:21)
    at initializeLoader (node:internal/process/esm_loader:82:19)
    at async loadESM (node:internal/process/esm_loader:87:5)
    at async handleMainPromise (node:internal/modules/run_main:65:12)
anonrig commented 2 years ago

No, the library uses both the new and the old loader functions in order to support the old node.js versions. Therefore, you need a --no-warnings suffix to your node.js run command to omit this warnings.

georgecrawford commented 2 years ago

Thanks Yagiz!

George

On 24 Jan 2022, at 23:30, Yagiz Nizipli @.***> wrote:

 No, the library uses both the new and the old loader functions in order to support the old node.js versions. Therefore, you need a --no-warnings suffix to your node.js run command to omit this warnings.

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you commented.