search

testdouble / teenytest

A very simple, zero-config test runner for Node.js
MIT License
96 stars 14 forks source link

support Node v8 #58

Closed giltayar closed 4 years ago

giltayar commented 4 years ago

Due to the addition of code with import(...), Node v8 stopped being supported as Node v8 considers import to be a "syntax" error, so the runtime sniffing didn't work.

  1. I require a file with import only from Node v10 and above.
  2. I added Node v8 to the Travis matrix.
giltayar commented 4 years ago

@searls - unfortunately, for quibble to pass the tests on v8, we need this fix in teenytest.

searls commented 4 years ago

LOL, sure. Ok, JavaScript

giltayar commented 4 years ago

Thanks! Don't forget to publish teenytest and then quibble so that I can work on testdouble.js. Because of Typescript, I can't npm link to quibble (typescript keeps transpiling quibble and turning my import in quibble into a require, because quibble is symlinked and thus not in node_modules). Aaaaaarrgrh!

searls commented 4 years ago

Landed in 6.0.1 -- waiting for you to update the quibble build and then I'll bump it

searls commented 4 years ago

Ok, quibble should be ready for you to roll as of 0.6.0