search

testdouble / testdouble.js

A minimal test double library for TDD with JavaScript
MIT License
1.42k stars 142 forks source link

Replace usage of global with globalThis for better browser support #508

Closed maxbeatty closed 1 year ago

maxbeatty commented 1 year ago

I ran into the same issue as #438 and #471 but the workarounds didn't work. Our stack is TypeScript + esbuild + Karma + mocha (and hopefully testdouble 😀 ). Our library is completely browser-based so we only want to test in real browsers.

These changes are largely the same as #472 but also upgrades the supported node engine as mentioned in https://github.com/testdouble/testdouble.js/issues/471#issuecomment-933481803 . Node.js Release Schedule

searls commented 1 year ago

Great patch, thank you! Landed in v3.17.0