search

testdrivenio / testdriven-app-2.4

23 stars 8 forks source link

Fix #9 and #11 #11

Closed anson-vandoren closed 5 years ago

anson-vandoren commented 5 years ago

Fixes invalid HTML (Issue #9) and wrong entrypoint (Issue #10)

mjhea0 commented 5 years ago

@anson-vandoren - so the code is broken up by part: https://github.com/testdrivenio/testdriven-app-2.4/releases. Each of the tags represents the code at the end of the part. Since you're on part one, compare the code you have at the end of the part to the code here: https://github.com/testdrivenio/testdriven-app-2.4/tree/part1.

Does that help?

anson-vandoren commented 5 years ago

Based on the tag for Part 1:

  1. /services/users/Dockerfile-prod line 18 should copy from ./entrypoint-prod.sh, not ./entrypoint.sh
  2. The extra
and tags should be removed from /services/users/project/api/templates/index.html (lines 51 and 52)
mjhea0 commented 5 years ago

It should be copying from entrypoint.sh based on the text here: https://testdriven.io/courses/microservices-with-docker-flask-and-react/part-one-deployment/

mjhea0 commented 5 years ago

I'm closing this PR

anson-vandoren commented 5 years ago

@mjhea0 The text you linked is wrong. You created a entrypoint-prod.sh file that used gunicorn instead of flask server to use in production. So the Dockerfile-prod should be using entrypoint-prod.sh (with gunicorn), and not entrypoint.sh (with flask).