testdrivenio / testdriven-app-2.4

23 stars 8 forks source link

Missing entrypoint bash script for staging environment #8

Closed AchilleasMich closed 5 years ago

AchilleasMich commented 5 years ago

On tag part4, the file entrypoint-stage.sh is missing from the directory services/users/ but it is required in the staging dockerfile. https://github.com/testdrivenio/testdriven-app-2.4/blob/57bab930925b56403c5950666ba35b6b66c5cf9c/services/users/Dockerfile-stage#L17-L18

There is also no reference of it on the corresponding page of the course

Having a look also at the master branch and the subsequent tags, it seems like the file exists in the place of the entrypoint-prod.sh script, which is referenced by /services/users/Dockerfile-prod file but is not used eventually as an entry point. It is just copied to the image https://github.com/testdrivenio/testdriven-app-2.4/blob/3d8f098c9b783ae296923b49d1eab08ef6125595/services/users/Dockerfile-prod#L17-L24