testing-cabal / mock

The Python mock library
https://docs.python.org/dev/library/unittest.mock.html
BSD 2-Clause "Simplified" License
536 stars 107 forks source link

Remove redundant license parameter and fix typo #474

Closed blag closed 4 years ago

blag commented 5 years ago

The Python packaging specifications indicate that the license parameter to setup() should be used in one of the following cases:

This PR removes the explicit license parameter since the usage for this project does not fit any of those cases and it makes it more difficult to use tools like pip-licenses since it is not consistent with other projects that just have License :: OSI Approved :: BSD License as one of their trove classifiers.

Please note that this does not change the license of the project in any way, and since this project already has a License :: OSI Approved :: BSD License trove classifier the license parameter is redundant.

Furthermore, I believe that the classifier option should be pluralized to classifiers, according to the setuptools documentation for setup.cfg (see the example).

cjw296 commented 4 years ago

Closing as dupe of #475

blag commented 4 years ago

Sorry, I didn't notice that I had opened a duplicate PR. I edited this in GitHub and the first time I committed - to blag:patch-1- it errored out (so I figured it didn't open a PR). Apologies for the noise.