testing-cabal / testtools

Testtools - tasteful testing for python
https://testtools.readthedocs.io/en/latest/
Other
95 stars 88 forks source link

expectThat works under AsynchronousDeferredRunTest #194

Closed jml closed 8 years ago

jml commented 8 years ago

AsynchronousDeferredRunTest has an unfortunate bug: if expectThat is called and fails, the test passes. See https://bugs.launchpad.net/testtools/+bug/1532452.

This is a critical bug.

There's a deeper bug in our testing strategy for RunTest. However, that will be vastly easier to address after #165 lands (and maybe after #181, which will provide us with an interface library), so I'm not tackling it here.

Review on Reviewable

rbtcollins commented 8 years ago

LGTM