Move all Twisted support code to twistedsupport package

testing-cabal / testtools

Testtools - tasteful testing for python

https://testtools.readthedocs.io/en/latest/

Other

95 stars 88 forks source link

Move all Twisted support code to twistedsupport package #202

Closed jml closed 8 years ago

jml commented 8 years ago

Intent is purely to move code around without causing behavior change, so that all the Twisted stuff is in one spot.

Move all Twisted support code to private modules in testtools.twistedsupport package
Export all public code from testtools.twistedsupport package
Continue to export public code from old locations (e.g. so testtools.deferredruntest.AsynchronousDeferredRunTest still works)
Move all tests for Twisted support code to testtools.tests.twistedsupport, to parallel matchers
Move NeedsTwistedTestCase to its own helper module, rather than importing from test_spinner as before

jml commented 8 years ago

Rebased on recent changes to master. No behavioural changes. Will merge in 24 hours unless I hear anything.

rbtcollins commented 8 years ago

Review status: 0 of 14 files reviewed at latest revision, 1 unresolved discussion.

testtools/deferredruntest.py, line 1 [r1] (raw file): It's my understanding the Copyright statements require years to be valid.

Comments from the review on Reviewable.io

rbtcollins commented 8 years ago

Assuming its all just a move, then it seems fine to me, modulo the copyright statement thing.

jml commented 8 years ago

Thanks. Copyright years restored & bumped (I don't know if it's required or not, but IP minutiae is even more tedious than resolving needless diff conflicts).

Merged as e571d9c.

jml commented 8 years ago

Reverted as 092d434. The Travis CI build is failing and I shouldn't have merged it in the first place.