search

testing-cabal / testtools

Testtools - tasteful testing for python
https://testtools.readthedocs.io/en/latest/
Other
95 stars 88 forks source link

Remove old Python 2.6 code #265

Closed hugovk closed 6 years ago

hugovk commented 7 years ago

Support for Python 2.6 and 3.2 was dropped in https://github.com/testing-cabal/testtools/pull/198, but tests and docs for the time being.

This removes some of the old code for Python 2.6 (and a bit of docs).

hugovk commented 7 years ago

Looks like that removed a bit much for the CI, I'll take another look!

hugovk commented 7 years ago

There we go. I've updated it so TestProgram isn't removed from run.py. It says "Delete when 2.7 is the oldest supported version" but a little more care is needed when doing so.

https://github.com/testing-cabal/testtools/blob/bfc88a45a3d94b4b030f9210471b2f700d294f15/testtools/run.py#L112-L260

hugovk commented 7 years ago

Here's pip installs for testtools from PyPI from the last month:

$ pypinfo --percent --pip testtools pyversion
python_version percent download_count
-------------- ------- --------------
2.7              92.5%        186,663
3.5               4.8%          9,694
3.6               1.3%          2,723
3.4               1.1%          2,166
2.6               0.2%            444
3.3               0.1%            169
3.7               0.0%             16
None              0.0%              2
hugovk commented 6 years ago

@freeekanayaka Hello, any thoughts on this PR (and #264)? Thank you!

rbtcollins commented 6 years ago

Thank you for this cleanup, its awesome. Sorry it sat around for ages; I've been stupidly busy recently. Would you be interested in helping maintain testtools?

hugovk commented 6 years ago

You're welcome! Sorry, I don't think I'll be able to maintain testtools.

However, Python 3.3 is also EOL and no longer receiving security updates, and only accounts for 0.1% of the downloads. Would you like a PR to remove that too?

rbtcollins commented 6 years ago

Yes please.

To be clear, I'm not asking for lots of code contrib, more review-and-merge things from other folk. You're putting up consistently sane PRs so I'm trusting your instincts. The offer (would need agreement from the rest of the team) is open indefinitely, let me know if you change your mind :).

hugovk commented 6 years ago

Thanks, see PR https://github.com/testing-cabal/testtools/pull/266.

hugovk commented 4 years ago

@rbtcollins Hello again! I'd like to help maintain testtools, or at least to get things ready for a release (it's 2.5 years since the last one), and prepare for the Python 2.7 EOL on 2020-01-01. Thanks!

rbtcollins commented 4 years ago

Hi! let me ping some other maintainers who are more active. @testing-cabal/core I would be delighted to have more help!