testing-cabal / testtools

Testtools - tasteful testing for python

https://testtools.readthedocs.io/en/latest/

Other

94 stars 88 forks source link

Drop support for EOL 3.5 #309

Closed hugovk closed 2 years ago

hugovk commented 3 years ago

Also:

Upgrade Python syntax with https://github.com/asottile/pyupgrade --py36-plus
Update and simplify GHA test workflow

hugovk commented 3 years ago

Yep, that sounds reasonable, please see https://github.com/testing-cabal/testtools/pull/310 for adding 3.9.

After that's merged (to avoid conflicts), I'll rebase and update this one. Thanks!

hugovk commented 3 years ago

I've created https://github.com/testing-cabal/testtools/pull/313 to note 2.5.0 is the last release with Python 3.5 support.

PR #310 is merged and I've rebased this. The NEWS in this PR can be updated once 2.5.0 is out.

hugovk commented 3 years ago

Two CI failures:

3.10-dev

I get the same on master:

https://github.com/hugovk/testtools/runs/3170432249?check_suite_focus=true https://github.com/testing-cabal/testtools/pull/309/checks?check_run_id=3170451427

pypy3

I don't get this on my PR build:

https://github.com/hugovk/testtools/runs/3170451055?check_suite_focus=true https://github.com/testing-cabal/testtools/pull/309/checks?check_run_id=3170451480

hugovk commented 2 years ago

Merge conflict resolved!

Is there anything more needed here? Thanks!

stephenfin commented 2 years ago

@hugovk Can you rebase this so we can pick up new test runs?

hugovk commented 2 years ago

Rebased!

This needs the 3.5 status check being marked as NOT required.

At the same time, the new 3.10 one can be marked as required.

hugovk commented 2 years ago

Updated to add a final, noop job to indicate success:

Its success depends on the build step fully passing. So instead of needing to https://github.com/testing-cabal/testtools/pull/309#issuecomment-1031459025 each and every time a Python version is added to or removed from the matrix, we can just add this new "test successful" as the required check.

hugovk commented 2 years ago

Closing this year-old PR to clear my list, happy to re-open if you want to merge :)

jelmer commented 2 years ago

Sorry about that. If you reopen, I promise I'll take a look at merging it.

hugovk commented 2 years ago

No problem, re-opened!

jelmer commented 2 years ago

Finally figured out how to mark the 3.5 tests as no longer required :)

stephenfin commented 2 years ago

We probably want to do 3.6 next. I think that's EOL now too

hugovk commented 2 years ago

Yes, 3.6 was EOL in December 2021 (3.7 will be June 2023).

https://endoflife.date/python