testing-cabal / testtools

Testtools - tasteful testing for python
https://testtools.readthedocs.io/en/latest/
Other
94 stars 88 forks source link

Fix pypy tests in test_testresult.py #358

Closed cclauss closed 10 months ago

cclauss commented 10 months ago

Fixes #333

Test both supported versions of PyPy3. https://www.pypy.org/download.html

~:-(. Both fail in similar ways.~

With two spaces less, pypy3.9 now passes but pypy3.10 fails.

With marker = '^^^' if sys.version_info >= (3, 10) else '^' everyone seems happy.

Perhaps add Py3.11, Py3.12, Pypy3.9, and Pypy3.10 to the Required tests below.

See https://github.com/testing-cabal/testtools/pull/356#issuecomment-1767718448 for the Some checks haven’t completed yet message below.

cclauss commented 10 months ago

@jelmer Why does the final test never run?

jelmer commented 10 months ago

@jelmer Why does the final test never run?

Hmm, which one?

cclauss commented 10 months ago

Now I see… build/pypy is required but that test is now renamed to build/pypy3.9 or build/pypy3.10 but the required list did not update with the rename. See https://github.com/testing-cabal/testtools/pull/356#issuecomment-1767718448 for the Some checks haven’t completed yet message below.

jelmer commented 10 months ago

I've updated the list just now.