search

testing-cabal / testtools

Testtools - tasteful testing for python
https://testtools.readthedocs.io/en/latest/
Other
94 stars 88 forks source link

Format code with ruff #370

Closed jelmer closed 8 months ago

bigjools commented 9 months ago

It's a bit tragic that ruff doesn't have black's setting skip-string-normalization.

bigjools commented 9 months ago

FWIW I am great with merging this but let's get a second opinion.

jelmer commented 9 months ago

I'm actually quite a fan of string normalization, but could be possibly be persuaded to port skip-string-normalization to ruff.

bigjools commented 9 months ago

Yeah I don't mind it too — except when you completely destroy the current git blame on a mature code base.

jelmer commented 9 months ago

I'll merge sometime in 2024 if there are no objections.

stephenfin commented 8 months ago

Yeah I don't mind it too — except when you completely destroy the current git blame on a mature code base.

Just create a .git-blame-ignore-revs file. GitHub respects that and you can configure your local Git to do the same. I stick this header into the file each time I create one:

# You can configure git to automatically use this file with the following config:
# git config --global blame.ignoreRevsFile .git-blame-ignore-revs

I'm a-okay with this change also, fwiw.

bigjools commented 8 months ago

Just create a .git-blame-ignore-revs file. GitHub respects that and you can configure your local Git to do the same. I stick this header into the file each time I create one:

# You can configure git to automatically use this file with the following config:
# git config --global blame.ignoreRevsFile .git-blame-ignore-revs

TIL!