testing-library / cypress-testing-library

🐅 Simple and complete custom Cypress commands and utilities that encourage good testing practices.
http://npm.im/@testing-library/cypress
MIT License
1.8k stars 152 forks source link

fix: allow cypress@5 as peer dependency #149

Closed SimenB closed 4 years ago

SimenB commented 4 years ago

What:

Up peer dep to the fresh v5 release

Why:

To avoid a warning when installing

How:

GitHub UI

Checklist:

Worked fine except for the warning locally 👍

nickserv commented 4 years ago

What's the warning? Should we merge despite it or wait?

SimenB commented 4 years ago

I'm assuming they meant that using v5 worked fine except for the peer dependency warning which this pr will fix

lkappeler commented 4 years ago

Exactly

kentcdodds commented 4 years ago

Sorry, I didn't notice this PR and I updated it without triggering a release. I'll push one out now. Sorry I missed the PR.

SimenB commented 4 years ago

No problem at all 👍