testing-library / cypress-testing-library

πŸ… Simple and complete custom Cypress commands and utilities that encourage good testing practices.
http://npm.im/@testing-library/cypress
MIT License
1.8k stars 153 forks source link

Fix findByRole() and findAllByRole() type definition to check role name #173

Closed shibukawa closed 3 years ago

shibukawa commented 3 years ago

What:

Fix findByRole() and findAllByRole() type definition to check role name as same as upstream @testing-library/dom does.

Why:

Current type definition uses Matcher type this is for jQuery selector.

How:

Switch role name type to ByRoleMatcher that is used in @testing-library/dom.

Checklist:

I confirmed VSCode shows role names in completion word list.

γ‚Ήγ‚―γƒͺγƒΌγƒ³γ‚·γƒ§γƒƒγƒˆ 2021-02-20 22 09 22
github-actions[bot] commented 3 years ago

:tada: This PR is included in version 7.0.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

shibukawa commented 3 years ago

Thank you for your great product.