search

testing-library / cypress-testing-library

🐅 Simple and complete custom Cypress commands and utilities that encourage good testing practices.
http://npm.im/@testing-library/cypress
MIT License
1.8k stars 152 forks source link

Add Loggable to accepted options of commands since it works at runtime #181

Closed Andarist closed 3 years ago

Andarist commented 3 years ago

What:

Add log?: boolean to the options of all commands.

Why:

This is already supported at runtime: https://github.com/testing-library/cypress-testing-library/blob/03b0309dc8d5e4d13b9307baa89a16aaa2ba9419/src/index.js#L21-L26

How:

Just edited the correct .d.ts and checked this change in my project.

Checklist:

NicholasBoll commented 3 years ago

@all-contributors please add @Andarist for code :)

allcontributors[bot] commented 3 years ago

@NicholasBoll

I've put up a pull request to add @Andarist! :tada:

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 7.0.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket: