testing-library / cypress-testing-library

🐅 Simple and complete custom Cypress commands and utilities that encourage good testing practices.
http://npm.im/@testing-library/cypress
MIT License
1.8k stars 152 forks source link

fix: allow cypress@v7 in peer dependency range #182

Closed SimenB closed 3 years ago

SimenB commented 3 years ago

What:

To not have a peer dep warning when installing

Why:

https://github.com/cypress-io/cypress/releases/tag/v7.0.0

How:

GH Editor

Checklist:

JeremyGrieshop commented 3 years ago

NPM7 currently blocks installing cypress@7.x unless you use the --legacy-peer-deps option, so this is a requirement for that, I believe.

SimenB commented 3 years ago

@nickmccurdy ping 🙂

alexkrolick commented 3 years ago

image

CI is failing for some reason

SimenB commented 3 years ago

Yeah, it seemed super transient, so I didn't bother. Retriggering seems to have fixed it 👍

joelgrimberg commented 3 years ago

so how long will it take to be released? can't wait :)

thanks to all of you for taking the effort!

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 7.0.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

alexkrolick commented 3 years ago

Sorry, walked away after re-triggering. Looks like release worked fine.