testing-library / cypress-testing-library

🐅 Simple and complete custom Cypress commands and utilities that encourage good testing practices.
http://npm.im/@testing-library/cypress
MIT License
1.8k stars 152 forks source link

Testing library command timeouts doesn't register with the timeout-bar in the Cypress test-runner #217

Closed Svish closed 1 year ago

Svish commented 2 years ago

What you did:

Added a timeout to findByRole, like this:

    cy.findByRole('button', {
      name: 'Not existing',
      timeout: 120_000,
    }).click();

What happened:

The timeout-bar of running/waiting testing-library commands in the Cypress test-runner finishes way before 120 seconds are up. Looks to take around 10 seconds for it to finish? This is the progress-bar I'm talking about:

image

If I use timeout on regular cypress commands, like cy.get('foobar', { timeout: 120_000 }), then the timeout-bar works correctly and does take 120 seconds to pass.

Problem description:

The timeout-option of testing-library commands doesn't seem to register correctly with the timeout-bar in the Cypress test-runner, like other commands do.

Suggested solution:

Timeout option on testing-library commands, should work and display the same as for other commands in the Cypress test-runner.

JavierMartinz commented 2 years ago

Any workaround for this? I'm also experiencing this issue.

github-actions[bot] commented 1 year ago

:tada: This issue has been resolved in version 8.0.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket: