search

testing-library / cypress-testing-library

🐅 Simple and complete custom Cypress commands and utilities that encourage good testing practices.
http://npm.im/@testing-library/cypress
MIT License
1.8k stars 152 forks source link

Cypress test builds broken because latest release of `@testing-library/dom` (8.18.0) #231

Closed sneridagh closed 1 year ago

sneridagh commented 1 year ago

Relevant code or config

Reproduction repository: https://github.com/plone/ploneconf.org/actions/runs/3080420601/jobs/4979205093#step:7:138

Problem description: cypress-testing-library has a caret dependency on @testing-library/dom.

https://github.com/testing-library/cypress-testing-library/blob/main/package.json#L44

Latest @testing-library/dom (8.18.0) has a problem in the dist ESM file:

https://github.com/testing-library/dom-testing-library/issues/1169

Therefore, all projects depending on cypress-testing-library will break when they get the latest @testing-library/dom.

sneridagh commented 1 year ago

Closing as this was fixed in https://github.com/testing-library/dom-testing-library/issues/1169 via https://github.com/testing-library/dom-testing-library/pull/1170, and released: https://www.npmjs.com/package/@testing-library/dom/v/8.18.1

Cypress is meant to Webpack compile import @testing-library/cypress/add-commands for the browser as well, so all its dependencies should be also able to do so.