testing-library / cypress-testing-library

🐅 Simple and complete custom Cypress commands and utilities that encourage good testing practices.
http://npm.im/@testing-library/cypress
MIT License
1.8k stars 152 forks source link

@testing-library/cypress causes non-cypress tests to fail #252

Open OVO-Josh opened 1 year ago

OVO-Josh commented 1 year ago

Relevant code or config

What you did:

After installing @testing-library/cypress, multiple unit tests written in @testing-library/react started to break.

What happened:

Prior to installing, the following unit test worked:


test("Add buy request and remove buy request buttons work", async () => {
  const user = userEvent.setup();
  render(<NewTradePage />);
  await user.click(screen.getAllByText("Add Buy Request")[0]);
  expect(screen.getByText("Requested Buy Volume 2")).toBeInTheDocument();
  await user.click(screen.getAllByText("Remove Buy Request")[0]);
  expect(screen.queryByText(/Requested Buy Volume 2 (MWh)/)).toBeNull();
});

After installing, I get the following error


TestingLibraryElementError: Unable to find an element with the text: Requested Buy Volume 2.

Suggested Solution:

I'm guessing this is due to @testing-library/react requiring version 8.5 of @testing-library/dom, whereas @testing-library/cypress requires version 8.1 - so maybe bumping the dependencies of the library?

AlbericTrancart commented 1 year ago

Bumping this issue, we cannot use this lib as a lot of our React / Jest tests are breaking if we try to install it. (we use RTL v14.0.0)

=> Found "@testing-library/dom@8.20.0"
info Reasons this module exists
   - "@testing-library#cypress" depends on it
   - Hoisted from "@testing-library#cypress#@testing-library#dom"
info Disk size without dependencies: "3.84MB"
info Disk size with unique dependencies: "6.65MB"
info Disk size with transitive dependencies: "7.18MB"
info Number of shared dependencies: 19
=> Found "@testing-library/react#@testing-library/dom@9.2.0"
info This module exists because "@testing-library#react" depends on it.
info Disk size without dependencies: "2.96MB"
info Disk size with unique dependencies: "5.77MB"
info Disk size with transitive dependencies: "6.3MB"
info Number of shared dependencies: 19
Done in 0.98s.