Use Cypress.Commands.overwriteQuery when adding a command that already exists

testing-library / cypress-testing-library

🐅 Simple and complete custom Cypress commands and utilities that encourage good testing practices.

http://npm.im/@testing-library/cypress

MIT License

1.8k stars 152 forks source link

Use Cypress.Commands.overwriteQuery when adding a command that already exists #256

Open mohsen1 opened 1 year ago

mohsen1 commented 1 year ago

We're running to similar issues reported here https://github.com/testing-library/cypress-testing-library/pull/238

Some commands already exists in the Cypress namespace. To make this library future proof, I'm using the override API to override commands if Cypress adds similarly named commands to list of its commands.

In our case we ran into issues for the findAllByLabelText command.

[ ] Documentation
[x] Tests
[ ] Ready to be merged

FaelCaporali-brickup commented 11 months ago

please release it! multiple problem solver

preslavpetkov commented 6 months ago

Do you need any help with this PR?