fix: update testing-libary-dom to 9

testing-library / cypress-testing-library

🐅 Simple and complete custom Cypress commands and utilities that encourage good testing practices.

http://npm.im/@testing-library/cypress

MIT License

1.8k stars 152 forks source link

fix: update testing-libary-dom to 9 #262

Closed TomPridham closed 11 months ago

TomPridham commented 11 months ago

What: Updating testing-library-dom to the latest version

Why: There were breaking changes in 8->9. Adding this library broke most of our existing jest tests because it requires testing-library-dom^8.2.1, but the latest testing-library-react requires testing-library-dom^9.0.0

How: Updates the dependency and fixes a test failure caused by one of the breaking changes in testing-library-dom

Checklist:

[x] Documentation
[x] Tests
[x] Ready to be merged

github-actions[bot] commented 11 months ago

:tada: This PR is included in version 10.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

kentcdodds commented 11 months ago

Keep in mind that a new version of @testing-library/dom is on the horizon, so we'll have another major version bump soon, but I thought y'all have waited long enough already.