crutchcorn commented 2 years ago

What: Update the dev dependency kcd-scripts

Why: To remain up-to-date with newer sub-dependencies

How: Update kcd-scripts, fix various linting warnings using eslint-disable-next-line where relevant

Checklist:

[x] Documentation added to the docs site N/A
[x] Tests N/A
[x] TypeScript definitions updated N/A
[x] Ready to be merged

I was working on a project with an extremely similar codebase (literally based on this one) and found that the newer version of the kcd-scripts dependency was slightly tricky to update. I figured I'd submit an upstream PR to help avoid duplicative development time :)

codesandbox-ci[bot] commented 2 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 74f27394866df689a2759666fc09bb713983eac5:

Sandbox	Source
react-testing-library-examples	Configuration

codecov[bot] commented 2 years ago

Codecov Report

Merging #1134 (f6d0604) into main (4f965e9) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head f6d0604 differs from pull request most recent head 74f2739. Consider uploading reports for the commit 74f2739 to get more accurate results

@@            Coverage Diff            @@
##              main     #1134   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        25    +1     
  Lines          989       985    -4     
  Branches       322       322           
=========================================
- Hits           989       985    -4

Flag	Coverage Δ
node-12	`100.00% <100.00%> (ø)`
node-14	`100.00% <100.00%> (ø)`
node-16	`100.00% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/helpers.js	`100.00% <ø> (ø)`
src/queries/label-text.ts	`100.00% <100.00%> (ø)`
src/config.ts	`100.00% <0.00%> (ø)`
src/screen.ts	`100.00% <0.00%> (ø)`
src/event-map.js	`100.00% <0.00%> (ø)`
src/pretty-dom.js	`100.00% <0.00%> (ø)`
src/suggestions.js	`100.00% <0.00%> (ø)`
src/queries/role.js	`100.00% <0.00%> (ø)`
src/shared.ts	`100.00% <0.00%> (ø)`

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

eps1lon commented 1 year ago

Thanks but we landed this in https://github.com/testing-library/dom-testing-library/pull/1208.

testing-library / dom-testing-library

chore: upgrade kcd-scripts dev dependency #1134

Codecov Report