testing-library / dom-testing-library

πŸ™ Simple and complete DOM testing utilities that encourage good testing practices.
https://testing-library.com/dom
MIT License
3.26k stars 467 forks source link

feat: add name hint to missing error in find by queries #1143

Closed dolevoper closed 2 years ago

dolevoper commented 2 years ago

What: Resolves: https://github.com/testing-library/dom-testing-library/issues/970

Checklist:

codesandbox-ci[bot] commented 2 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9cd3e2bc8f0fc4240cd8e4e1771039b5a019e0f5:

Sandbox Source
react-testing-library-examples Configuration
codecov[bot] commented 2 years ago

Codecov Report

Merging #1143 (9cd3e2b) into main (29a17cb) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1143   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          985       987    +2     
  Branches       325       325           
=========================================
+ Hits           985       987    +2     
Flag Coverage Ξ”
node-12 100.00% <100.00%> (ΓΈ)
node-14 100.00% <100.00%> (ΓΈ)
node-16 100.00% <100.00%> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
src/queries/role.js 100.00% <100.00%> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 29a17cb...9cd3e2b. Read the comment docs.

eps1lon commented 2 years ago

@all-contributors add @dolevoper for code

allcontributors[bot] commented 2 years ago

@eps1lon

I've put up a pull request to add @dolevoper! :tada:

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 8.15.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: