testing-library / dom-testing-library

🐙 Simple and complete DOM testing utilities that encourage good testing practices.

https://testing-library.com/dom

MIT License

3.26k stars 467 forks source link

feat: add a return value from logTestingPlaygroundURL #1144

Closed Lirlev48 closed 2 years ago

Lirlev48 commented 2 years ago

Adding a return value to logTestingPlaygroundURL function besides the log - Resolves #1125

logTestingPlaygroundURL() used to prints the value directly to the stdout of the running process, The values was hidden in the log window

Adding a return statement to the logTestingPlaygroundURL function

Checklist:

[ ] Documentation added to the docs site
[X] Tests
[X] TypeScript definitions updated
[X] Ready to be merged

Will add documentation to testing-library-docs after the PR will be completed.

codesandbox-ci[bot] commented 2 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4bcb210acc3e4559d91ae2e323ff00d8517becbb:

Sandbox	Source
react-testing-library-examples	Configuration

Lirlev48 commented 2 years ago

docs for this PR https://github.com/testing-library/testing-library-docs/pull/1105

codecov[bot] commented 2 years ago

Codecov Report

Merging #1144 (4bcb210) into main (7b10f73) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1144   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          987       989    +2     
  Branches       325       325           
=========================================
+ Hits           987       989    +2

Flag	Coverage Δ
node-12	`100.00% <100.00%> (ø)`
node-14	`100.00% <100.00%> (ø)`
node-16	`100.00% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/screen.ts	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7b10f73...4bcb210. Read the comment docs.