testing-library / dom-testing-library

πŸ™ Simple and complete DOM testing utilities that encourage good testing practices.
https://testing-library.com/dom
MIT License
3.26k stars 467 forks source link

fix: Pin supported target environment #1170

Closed eps1lon closed 1 year ago

eps1lon commented 1 year ago

What:

Closes https://github.com/testing-library/dom-testing-library/issues/1169

Why:

A minor release created a build with that contained syntax that we don't support yet.

How:

Run npx browserslist defaults with a version of caniuse-lite that was used at the time of the latest good release. That snapshot is now contained in our manifest and ensures build tools transpile to this target. Having "defaults" as the target environment is too weak of a contract to have. Now it's apparent that changing the target environment is considered a breaking change. We can decide in the next major release what a good matrix for supported runtimes is.

Checklist:

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a06325d4a11906f1f289d146700cceb8ef5d379a:

Sandbox Source
react-testing-library-examples Configuration
codecov[bot] commented 1 year ago

Codecov Report

Merging #1170 (a06325d) into main (ab8182c) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #1170   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          996       996           
  Branches       327       327           
=========================================
  Hits           996       996           
Flag Coverage Ξ”
node-12 100.00% <ΓΈ> (ΓΈ)
node-14 100.00% <ΓΈ> (ΓΈ)
node-16 100.00% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

eps1lon commented 1 year ago

Pinning kcd-scripts won't help, as we're not using latest

Please see the PR title and description. I'm not pinning kcd-scripts but everything.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 8.18.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

MatanBobi commented 1 year ago

@eps1lon, it looks like op_mob 64 isn't available as our CI failed for that in this PR and we should upgrade this to 73 but I'm not sure if that will add the nullish coalescing issue again.

CC: @timdeschryver