Closed idanen closed 5 months ago
Hi @idanen!
Thanks for opening this one :)
Looking at the spec, meter
doesn't have an implicit role:
https://www.w3.org/TR/html-aria/
Where did you see that it does? Remember that aria-query
follows the spec as is and browsers might not.
Oh.. Actually I followed Chrome's behavior in its accessibility tab, which shows a role of meter
on <meter />
elements.
So I guess this can be closed then?
Yeah, sorry about that :)
Maybe we should re-open this issue? Looks like the spec now specifies that meter is an implicit role.
https://www.w3.org/TR/html-aria/ https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meter
Uh oh! @Blacktiger, the image you shared is missing helpful alt text. Check https://github.com/testing-library/dom-testing-library/issues/1171#issuecomment-1800395640.
Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.
Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
Thanks @Blacktiger!
I've tested this in our alpha
version of @testing-library/dom
and it works. We're testing it in multiple places to check for regressions so it's not yet released. If you want, you can install it manually also and see if that works for you.
For now we just used a data-testid, but I'll definitely want to get our version upgraded when you guys do the final release. We really like how testing-library works and have been very happy with it, so thanks for all the work you guys have done on it.
:tada: This issue has been resolved in version 10.0.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
@testing-library/dom
version: ^8.17.0Relevant code or config:
What you did:
Tried to fetch by (implicit) meter role
What happened:
Failed to get element
Reproduction:
https://codesandbox.io/s/react-testing-library-getbyrole-meter-forked-ziqc09
Problem description:
Should be able to fetch a
meter
element by implicit roleSuggested solution: