search

testing-library / dom-testing-library

🐙 Simple and complete DOM testing utilities that encourage good testing practices.
https://testing-library.com/dom
MIT License
3.26k stars 466 forks source link

Update `aria-query` to `5.1.1` #1182

Closed mrienstra closed 1 year ago

mrienstra commented 1 year ago

This repo currently specifies aria-query ^5.0.0.

aria-query 5.0.0 uses core-js-compat 3.18.1.

aria-query 5.1.1 uses core-js-compat 3.25.5.

(in both cases via @babel/preset-env)

Versions of core-js-compat older than 3.23.3 show this warning during yarn install, at for me locally, running node v18.9.0 & yarn 3.2.3:

core-js-pure@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js-pure.

(Granted, due to the ^ in ^5.0.0, in some cases aria-query 5.1.1 will be used without any changes, unless constrained by an existing lockfile)

mrienstra commented 1 year ago

Whoops, didn't realize this only affects core-js@<3.23.3 & core-js-pure@<3.23.3, but not core-js-compat@<3.23.3 -- for core-js-compat it's core-js-compat@<3.2.0.