testing-library / dom-testing-library

🐙 Simple and complete DOM testing utilities that encourage good testing practices.
https://testing-library.com/dom
MIT License
3.26k stars 466 forks source link

feat: Drop support for Node.js 12.x #1207

Closed eps1lon closed 1 year ago

eps1lon commented 1 year ago

BREAKING CHANGE: Minimum supported Node.js version is now 14.x

What:

Drop support for Node.js 12.x

Why:

Reached EOL in April 2022. Tooling is starting to drop Node.js 12.x (see JSDOM) as well so it's time to upgrade to be able to test compat with latest test frameworks (e.g. Jest).

How:

Targetting alpha for now. Want to batch this with https://github.com/testing-library/dom-testing-library/issues/1202 Look for occurence of "12" and update where appropriate. Also introducing Node.js 18.x into test matrix since that is now in Active LTS

Checklist:

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b092065aa02b68a65c104728443fd67cca91f520:

Sandbox Source
react-testing-library-examples Configuration
codecov[bot] commented 1 year ago

Codecov Report

Merging #1207 (b092065) into main (0ce0c70) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #1207   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          998       998           
  Branches       327       327           
=========================================
  Hits           998       998           
Flag Coverage Δ
node-12 ?
node-14 100.00% <ø> (ø)
node-16 100.00% <ø> (ø)
node-18 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

eps1lon commented 1 year ago

Do you think we should also add v19 to the test matrix?

Sure